[Kmymoney-devel] Review Request: BUG:312127 - Can't select Factor in New Investment Wizard

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107920/#review23995
-----------------------------------------------------------


Sorry, but I did not see your comment on a duplicate of the bug. I just fixed that similar to your proposed patch but a bit differently. So you can simply drop this review request here.

- Thomas Baumgart


On Dec. 26, 2012, 12:01 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107920/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2012, 12:01 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> m_onlineFactor is disabled when KNewInvestmentWizard(QWidget *parent) is called, but it does not get enabled until the wizard has been exited and re-entered.
> This fix creates a connect from the activation of the online source combo to m_onlineUpdatePage->slotCheckPage(QString()), so the online factor is enabled.
> 
> 
> This addresses bug 312127.
>     http://bugs.kde.org/show_bug.cgi?id=312127
> 
> 
> Diffs
> -----
> 
>   kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.cpp eff20a7 
> 
> Diff: http://git.reviewboard.kde.org/r/107920/diff/
> 
> 
> Testing
> -------
> 
> Checked that m_onlineFactor widget gets enabled when an online source is chosen, and that the new investment can be updated online.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121226/eb5b2c42/attachment.html>