[Kmymoney-devel] [Bug 312127] KMyMoney New Investment Wizard

allan agander93 at gmail.com
Mon Dec 24 13:00:40 UTC 2012


https://bugs.kde.org/show_bug.cgi?id=312127

allan <agander93 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |agander93 at gmail.com
         Resolution|DUPLICATE                   |---
     Ever confirmed|0                           |1

--- Comment #3 from allan <agander93 at gmail.com> ---
As far as I can see, m_onlineFactor is enabled at
KOnlineUpdateWizardPage::slotCheckPage(const QString& txt), which can be called
from KNewInvestmentWizard::KNewInvestmentWizard(QWidget *parent)
m_onlineUpdatePage->slotCheckPage(QString()) or from
KNewInvestmentWizard::init2(void).  the latter only getting called when editing
an existing security, or when an existing symbol has been entered.  So, it
seems the first call is the relevant one.

However, this call to slotCheckPage() is made with txt = QString(), so the
widget will not get enabled.  QString() could be replaced with a non-empty
string, but there seems little point in that.  Instead, why have the check for
a string in m_onlineFactor->setEnabled(!txt.isEmpty())?  Why not change it to
setEnabled(void))?  Why have the enabling conditional in a constructor?

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the KMyMoney-devel mailing list