[Kmymoney-devel] Review Request: Dialog window improvement - 'Enter scheduled transaction?'

[Łukasz Maszczyński]

> On Dec. 19, 2012, 11 a.m., Cristian Oneț wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 1424
> > <http://git.reviewboard.kde.org/r/107758/diff/1/?file=99847#file99847line1424>
> >
> >     I think that the amount formating should be done based on the precision of the currency which is involved here. But if that's not available it's OK like this.

Changed in rev.2, but please verify.

I used MyMoneySecurity::smallestCashFraction(), which in my belief deals with currency only, while the other method - smallestAccountFraction() - in my understanding deals with other security types (stock, mutual fund, bond). Unfortunately the code is not documented, so that's only my guess based on how MyMoneySecurity is used in other parts of KMM code.


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107758/#review23713
-----------------------------------------------------------


On Dec. 22, 2012, 8:58 a.m., Łukasz Maszczyński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107758/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2012, 8:58 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> The dialog window which pops up when an imported transaction matches a schedule now contains additional information helpful to the user: payee information and transaction amount. This helps the user to identify if the transaction and schedule should really be matched.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.h 886a5f1 
>   kmymoney/converter/mymoneystatementreader.cpp ef04d51 
> 
> Diff: http://git.reviewboard.kde.org/r/107758/diff/
> 
> 
> Testing
> -------
> 
> make test
> 
> 
> Thanks,
> 
> Łukasz Maszczyński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121222/7b861414/attachment.html>