[Kmymoney-devel] Review Request: added new check when matching imported transaction with a schedule: payee match

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107759/#review23738
-----------------------------------------------------------

Ship it!



kmymoney/dialogs/transactionmatchfinder.h
<http://git.reviewboard.kde.org/r/107759/#comment18161>

    s/the/them/


- Thomas Baumgart


On Dec. 16, 2012, 4:07 p.m., Łukasz Maszczyński wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107759/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 4:07 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> When imported transactions are being matched with schedules and existing transactions, the payee of the imported transaction is disregarded. 
> 
> Example:
> 1. Create a schedule with following parameters:
> - named "Phone bill"
> - payment to "Telefonica"
> - amount: approximately 30 EUR
> - date: 5th of every month
> 
> 2. Import a transaction with the following parameters:
> - payee: "FooMart"
> - amount: 30.50 EUR
> - date: 6th
> 
> Actual result: match
> Expected result: no match, because the payees are known and mismatch.
> 
> This patch will allow a match of transactions if both refer to the same payee, or at least one of the transactions doesn't refer to any payee.
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactionmatchfinder.h e819ad98a6a3d2d9493f21a11f5cbfa707140f3c 
>   kmymoney/dialogs/transactionmatchfinder.cpp cf326e9db480ac471eba96129c448e181ecbf97b 
> 
> Diff: http://git.reviewboard.kde.org/r/107759/diff/
> 
> 
> Testing
> -------
> 
> make test 
> manual test of the case from the description
> 
> 
> Thanks,
> 
> Łukasz Maszczyński
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121219/b001cfb5/attachment.html>