[Kmymoney-devel] Review Request: Change annoying date input preview behaviour on Mac OSX

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106234/#review18158
-----------------------------------------------------------

Ship it!


Looks OK to me, though I don't have a MAC system here. If it works for you that's good enough.

- Thomas Baumgart


On Aug. 27, 2012, 2:21 p.m., Theo Spears wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106234/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 2:21 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Don't show passive popup with formatted date on Mac
> 
> There is already some code to do this, but it misses the case of when the date is updated. Showing the passive popup on OSX is bad because it steals focus from the date input box, and when focus is restored the cursor is moved back to the start of the input. This makes entering dates very annoying.
> 
> 
> Diffs
> -----
> 
>   kmymoney/widgets/kmymoneydateinput.cpp ce8cefb6d5733860c37ec8ca3c0c0e0c7bae890f 
> 
> Diff: http://git.reviewboard.kde.org/r/106234/diff/
> 
> 
> Testing
> -------
> 
> Compiled via MacPorts. Has the desired effect on my machine. 
> 
> 
> Thanks,
> 
> Theo Spears
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120828/0a8f64d4/attachment.html>