[Kmymoney-devel] [Bug 305573] KMyMoney instantly crashes upon assigning "Input Column" numbers during CSV file import

[allan]

https://bugs.kde.org/show_bug.cgi?id=305573

--- Comment #9 from allan <agander93 at gmail.com> ---
(In reply to comment #8)
> Please try to use any of the Qt container classes. it should help you with
> the dynamics a lot. QVector sounds like a good candidate. See
> http://qt-project.org/doc/qt-4.8/containers.html for an overview.

I think the reference to 'dynamic' was perhaps a bit misleading.  What was
being referred to was to replace the original fixed array size with one
depending on the file size.  The actual array itself requires little
manipulation, no insertions or deletions, apart from when a ne file is loaded.

I looked at QVector and didn't see anything there that was not provided by
replacing the QString array with a QStringList.

The major problem was in the relocation of the 'setting sizes' code  away from
the ctor to the readFile routine.  This in turn lead to a number of connect
problems.

All now seems to be well, both for banking and investments.  The changes are
not insignificant - 
 kmymoney/plugins/csvimport/csvdialog.cpp        |  308 ++++++++++++-----------
 kmymoney/plugins/csvimport/csvdialog.h          |    5 +-
 kmymoney/plugins/csvimport/investmentdlg.cpp    |   32 ---
 kmymoney/plugins/csvimport/investmentdlg.h      |    7 -
 kmymoney/plugins/csvimport/investprocessing.cpp |  231 +++++++++++-------
 kmymoney/plugins/csvimport/investprocessing.h   |    5 +-
 6 files changed, 316 insertions(+), 272 deletions(-)

So, do I need to go through reviewboard?  At the moment, the fixes apply to the
stable release only.  The reason is that I am some way through a biggish
tidy-up of the development version, and am intending to include the bug fix in
with them.

-- 
You are receiving this mail because:
You are the assignee for the bug.