[Kmymoney-devel] Review Request: An extra check that should be necessary in PivotTable::assignCell determined just by looking at the code

[Alvaro Soliverez]

> On Jan. 6, 2012, 12:08 p.m., Cristian Oneț wrote:
> > kmymoney/reports/pivottable.cpp, line 1210
> > <http://git.reviewboard.kde.org/r/103636/diff/1/?file=45804#file45804line1210>
> >
> >     After a bit of thought wouldn't it be better for this check to be moved inside the 'if (budget)' block?

Yes, it would be better to move it inside that block to only check when it's a budget report.
Sorry for the delay to answer


- Alvaro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103636/#review9611
-----------------------------------------------------------


On Jan. 6, 2012, 10:09 a.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103636/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2012, 10:09 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Looking at BUG 282107 I found a lot of reports with the same stack trace [1]. Some of the are reported in 4.5.0, 4.5.1 and others in 4.5.3.
> BUG 255135 was reported in 4.5.0 and fixed by Thomas in 4.5.2 (between 4.5.1 and 4.5.2) but as you can see from the other reports the bug is still there (the same stack trace).
> Since I can't reproduce those bugs I tried looking at the code and came to the conclusion that this check would be necessary since later a QList::operator[] is used without proper boundary checks. 
> 
> 
> [1] https://bugs.kde.org/buglist.cgi?query_format=specific&order=relevance+desc&bug_status=__all__&product=kmymoney4&content=getLcd
> 
> 
> This addresses bug 282107.
>     http://bugs.kde.org/show_bug.cgi?id=282107
> 
> 
> Diffs
> -----
> 
>   kmymoney/reports/pivottable.cpp 565c71b 
> 
> Diff: http://git.reviewboard.kde.org/r/103636/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120429/acf2f60a/attachment.html>