[Kmymoney-devel] Review Request: Some i18n improvements

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103622/#review13013
-----------------------------------------------------------


This looks all sensible to me.


And yes, why wouldn't one want to use this approach:

> -why are the month names as translatable strings in there, isn't it enough to call QDate::longMonthName()?

????

- Marko Käning


On Jan. 3, 2012, 8:25 p.m., Rolf Eike Beer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103622/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2012, 8:25 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> This is the beginning of some work needed to ease translators work. I was looking into the kmymoney.po file today and found a bunch of issues which I reported to the IRC channel and now copy in here:
> 
> -then there is a pushbutton labeled "Del", while usually "Delete" is used. Using the short form there will not give any benefits, as most translations will be longer anyway. Near that "Del" thing are some other very short texts, like "Upd", "Res", "Ren", and so on. As long as you don't put in a context that says the translation must not be longer than 3 characters this effort on short names is void
> -then 'Duplicate' has contexts 'Duplicate transaction' and 'To duplicate a split'. I would say the first context will fit the second place, too
> -there are 3 occurences of "From" without context, and one with context ">From (Date)". would be nice if the other 3 could be annotated, too. For stable branch (if applicable): only annotate those that would get "From (Date)", this will not break string freeze
> -then there is the tooltip "Select column containing amount field", once with and once without following dot. one has a context that is the text itself, the other has none. I suggest using the one with dot and without context
> -then there is the text "Select column containing date field", also with and without dot
> -the context is "verb, Select column containing number field." which doesn't look useful to me
> -there are some more tooltips with the context being "verb, <text of tooltip>"
> -there are a lot of "Total" with context "Total balance" (which is enough IMHO). Then there are 2 with "Total balance for ..." which can be merged in the above IMHO
> -why are the month names as translatable strings in there, isn't it enough to call QDate::longMonthName()?
> -kmymoney/plugins/csvimport/lines-datewizardpage.ui:241, 246, 251 have strings like "y m d". The translation fuzzy cache shows that such a string previously existed with the context "abbreviation of 'year', 'month', 'day'". I would like to see that context returning.
> -there are strings that start or end in whitespace, I'm not sure if that makes sense at all
> 
> I left out some parts of the chat that are already fixed by the attached patch. Some other lines are rearranged to make reading smoother as related lines are together. Please note that I'll not go to fix up the rest as there is additional knowledge needed about the program that I don't have and I don't really have time to go over the whole codebase. I hope this is still valueable for you as it may give you an idea of what needs to be touched.
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/settings/ksettingsregisterdecl.ui 8d99e48 
>   kmymoney/kmymoneyutils.cpp 0d524e2 
>   kmymoney/plugins/csvimport/separatorwizardpage.ui f9d07d3 
>   kmymoney/views/kmymoneyview.cpp 8369f66 
>   kmymoney/widgets/transaction.cpp bfaafbf 
>   kmymoney/wizards/newaccountwizard/kloanpaymentpagedecl.ui 6b7bf1e 
>   kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp a35cb16 
>   kmymoney/wizards/newloanwizard/summaryeditwizardpagedecl.ui 1c7de3e 
> 
> Diff: http://git.reviewboard.kde.org/r/103622/diff/
> 
> 
> Testing
> -------
> 
> None (not even compile tested)
> 
> 
> Thanks,
> 
> Rolf Eike Beer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120428/d6a192d2/attachment.html>