[Kmymoney-devel] Krazy2 problem?

[aga]

On Sun, 30 Oct 2011 19:00:07 -0400
Allen Winter <winter at kde.org> wrote:

> On Saturday 29 October 2011 5:53:44 PM you wrote:
> > On Sat, 29 Oct 2011 13:01:57 -0400
> > Allen Winter <winter at kde.org> wrote:
> > 
> > > On Friday 28 October 2011 10:03:35 AM you wrote:
> > > > Hi Allen
> > > > 
> > > > Thomas suggested I contact you regarding a problem I encountered
> > > > when running Krazy 2 yesterday using the tarball I had just
> > > > downloaded, on my plugins/csvimport folder in kmymoney.
> > > > 
> > > > Apart from a few minor issues, I got this:-
> > > > 
> > > > "5. Check for code that should be considered crashy.
> > > > [crashy]... 255 issues found".
> > > > 
> > > > I then tried against a known good version of my folder, and
> > > > that too failed.  Reverting to a somewhat older version of
> > > > Krazy, that worked. However, Thomas pointed me to this:-
> > > > 
> > > > "No, I don't see those on
> > > > 
> > > > http://ebn.kde.org/krazy/reports/extragear/office/kmymoney/index.html
> > > > ".
> > > > 
> > > > I wonder could you check against the KMyMoney repo., please.
> > > > 
> > > I don't see any problems.
> > > Maybe you have an old version of Krazy.  I recall there were
> > > problems with the 'crashy' checker a few weeks ago -- which I
> > > fixed in the meantime.
> > > 
> > > please make sure you have the most recent Krazy.
> > > 
> > > -Allen
> > > 
> > 
> > It was the master tarball that I downloaded on Thursday and used
> > immediately.  Has it changed since then?
> > 
> Ok, I just downloaded the tarball for the master tree and it looks ok.
> 
> try that one.
> 
> -Allen
> 

This is the code responsible.

int RedefineDlg::suspectType(const QString& info)
{
  displayLine(info);
  buildOkTypeList();
  for(int i = 0; i < m_typesList.count() ; i++) { //m_okTypeList.count()
    if(m_okTypeList.contains(m_typesList[i])) {
      m_widget->kcombobox_Actions->setItemIcon(i, m_iconYes);
    } else {
      m_widget->kcombobox_Actions->setItemIcon(i, m_iconNo);
    }
  }

  int ret = exec();
  if(ret == QDialog::Rejected)
    ret = KMessageBox::Cancel;
  return ret;
}

Allan