[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/
-----------------------------------------------------------

(Updated Nov. 29, 2011, 7:57 p.m.)


Review request for KMymoney.


Changes
-------

I tried to come up with the 2nd of the three test cases.

I assumed that setting the relevant values "lastImportedTransactionDate" and "lastStatementBalance" with equal dates would do the job to simulate a successful import of transactions. Since I didn't touch the balance of account and file I thought that the test should succeed as true, but doesn't.

That means I must be doing something wrong... 


Description
-------

Highlighting of online statement balance with red background and
highlighted text if file balance and online balance are different.
(This patch was put together from Thomas' and Cristian's advice on ML)


This addresses bug 287494.
    http://bugs.kde.org/show_bug.cgi?id=287494


Diffs (updated)
-----

  kmymoney/mymoney/mymoneyfile.h d44e2ea 
  kmymoney/mymoney/mymoneyfile.cpp f573f9a 
  kmymoney/mymoney/mymoneyfiletest.h ad5c687 
  kmymoney/mymoney/mymoneyfiletest.cpp a3c17ed 
  kmymoney/widgets/register.h 8cd1a32 
  kmymoney/widgets/register.cpp e62fe63 

Diff: http://git.reviewboard.kde.org/r/103264/diff/diff


Testing
-------

Yes


Screenshots
-----------

small snapshot showing the highlighted group marker
  http://git.reviewboard.kde.org/r/103264/s/345/


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111129/325c4552/attachment.html>