[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Marko Käning]

> On Nov. 27, 2011, 4:40 p.m., Thomas Baumgart wrote:
> > kmymoney/mymoney/mymoneyfile.h, line 1390
> > <http://git.reviewboard.kde.org/r/103264/diff/2/?file=42264#file42264line1390>
> >
> >     Mention how method behaves in case no online balance is available for the account.

Ah, I see, that's a must. The program-logic is such that the method is now called only when there is an online-balance. Certainly, once the method is available it could be used also in other situations, which makes such a test necessary. Thanks for the hint!


> On Nov. 27, 2011, 4:40 p.m., Thomas Baumgart wrote:
> > kmymoney/mymoney/mymoneyfile.h, line 1396
> > <http://git.reviewboard.kde.org/r/103264/diff/2/?file=42264#file42264line1396>
> >
> >     make that a const method by adding the word 'const' between ')' and ';'.

Sorry, my bad, I simply forgot to add it. Thanks.


> On Nov. 27, 2011, 4:40 p.m., Thomas Baumgart wrote:
> > kmymoney/mymoney/mymoneyfile.cpp, line 2761
> > <http://git.reviewboard.kde.org/r/103264/diff/2/?file=42265#file42265line2761>
> >
> >     Ooops, this won't work. You need to check if you have an online balance and in case you don't, return false. Add a test cases for
> >     
> >     a) no online balance available
> >     b) online balance matches
> >     c) online balance does not match

Will look into it.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/#review8538
-----------------------------------------------------------


On Nov. 27, 2011, 4:32 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103264/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2011, 4:32 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Highlighting of online statement balance with red background and
> highlighted text if file balance and online balance are different.
> (This patch was put together from Thomas' and Cristian's advice on ML)
> 
> 
> This addresses bug 287494.
>     http://bugs.kde.org/show_bug.cgi?id=287494
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h d44e2ea 
>   kmymoney/mymoney/mymoneyfile.cpp f573f9a 
>   kmymoney/widgets/register.h 8cd1a32 
>   kmymoney/widgets/register.cpp 39d991c 
> 
> Diff: http://git.reviewboard.kde.org/r/103264/diff/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Screenshots
> -----------
> 
> small snapshot showing the highlighted group marker
>   http://git.reviewboard.kde.org/r/103264/s/345/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111127/61551246/attachment.html>