[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Marko Käning]

> On Nov. 27, 2011, 1:54 a.m., Alvaro Soliverez wrote:
> > kmymoney/widgets/register.h, line 162
> > <http://git.reviewboard.kde.org/r/103264/diff/1/?file=42242#file42242line162>
> >
> >     The name is ambiguous.
> >     Perhaps something like isConsistentWithOnline might more descriptive
> 
> Marko Käning wrote:
>     The question is for me here, whether the already existing member function isErronous() was actually meant to be used for a purpose like this?
>     
>     Do we need the existing isErronous()? (Not only because of the wrong spelling, in general I mean, what else is it's purpose?) {AND there are two other classes with the same isErronous() around...}
>     
>     Apart from that I am of course willing to rename it according to your suggestion.
> 
> Thomas Baumgart wrote:
>     isErronous (OK, we need to fix the spelling problem at some point in time) is used inside transaction.cpp/h.  It's purpose is to signal a non-balanced transaction (sum of all splits is not zero) and the same flag could be used by the marker code.
> 
> Marko Käning wrote:
>     OK, I'll use the same flag then. (Was irritated by the hard-coded "return false;" in there.)
> 
> Thomas Baumgart wrote:
>     I'd call it 'default implementation' rather than 'hard-coded'   :)

;-) OK, I'm back in my box, already. :-)

BTW, since we still have the spelling issue with "nous" I did NOT mark this issue as FIXED for now.

And, I forgot to mention: I tested the 2nd version of my patch and it works. So, it seems, at least this patch could be shipped... :-)


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/#review8499
-----------------------------------------------------------


On Nov. 27, 2011, 2:20 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103264/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2011, 2:20 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Highlighting of online statement balance with red background and
> highlighted text if file balance and online balance are different.
> (This patch was put together from Thomas' and Cristian's advice on ML)
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h d44e2ea 
>   kmymoney/mymoney/mymoneyfile.cpp f573f9a 
>   kmymoney/widgets/register.h 8cd1a32 
>   kmymoney/widgets/register.cpp 39d991c 
> 
> Diff: http://git.reviewboard.kde.org/r/103264/diff/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Screenshots
> -----------
> 
> small snapshot showing the highlighted group marker
>   http://git.reviewboard.kde.org/r/103264/s/345/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111127/85379490/attachment.html>