[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/
-----------------------------------------------------------

(Updated Nov. 27, 2011, 2:20 p.m.)


Review request for KMymoney.


Changes
-------

As suggested I introduced

 MyMoneyFile::hasMatchingOnlineBalance(const MyMoneyAccount& account)

which is used to query whether a specific account is matching its online balance or not.

I removed my previously introduced 

 isErroneous(void)

and made use of the already existing

 isErronous(void)

so that eventually

 p->setErroneous(!MyMoneyFile::instance()->hasMatchingOnlineBalance(m_account));

can be used to set the flag m_erroneous (which is false by default).


Description
-------

Highlighting of online statement balance with red background and
highlighted text if file balance and online balance are different.
(This patch was put together from Thomas' and Cristian's advice on ML)


Diffs (updated)
-----

  kmymoney/mymoney/mymoneyfile.h d44e2ea 
  kmymoney/mymoney/mymoneyfile.cpp f573f9a 
  kmymoney/widgets/register.h 8cd1a32 
  kmymoney/widgets/register.cpp 39d991c 

Diff: http://git.reviewboard.kde.org/r/103264/diff/diff


Testing
-------

Yes


Screenshots
-----------

small snapshot showing the highlighted group marker
  http://git.reviewboard.kde.org/r/103264/s/345/


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111127/b5dce227/attachment.html>