[Kmymoney-devel] Review Request: CSVPlugin wizard version

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103142/
-----------------------------------------------------------

(Updated Nov. 15, 2011, 9:09 p.m.)


Review request for KMymoney.


Changes
-------

I started from scratch and this time no hitches, at least the patch file appears complete and all works as it should.

Apologies for the first effort.


Description
-------

This was submitted originally as http://svn.reviewboard.kde.org/r/6818/ on 28 October.

The two earlier versions of the plugin suffered from different difficulties in the UI.  A wizard approach has now been adopted, to give better guidance to the user of the flow in the UI.

Also, in the investment section of the earlier versions, only simple CSV files could be catered for, where the file contained just a single security.  When files from brokers become involved, this is a different kettle of fish all together.  I've added support for two brokers, Merril Lynch and Schwab.  Their files may contain several securities, and the investment activity type may not be in a separate column, but buried in a Detail column.  In fact, the requirements for just these two brokers were conflicting, and dealing with both correctly became pretty complex.  The names used to define the security may vary within a file and may be different from those in use by the user, so the user has the opportunity to edit the security names during the import process.

A further problem was that some files did not use ticker symbols on all investment lines, and this is necessary for compatibility with KMyMoney.  It will therefore be necessary for the user to add symbols to the input file beforehand, although as long as they are used consistently, they do not need to be 'real' symbols.


Diffs (updated)
-----

  kmymoney/plugins/csvimport/CMakeLists.txt 1ca4590 
  kmymoney/plugins/csvimport/bankingwizardpage.ui PRE-CREATION 
  kmymoney/plugins/csvimport/completionwizardpage.ui PRE-CREATION 
  kmymoney/plugins/csvimport/convdate.cpp c5e1bab 
  kmymoney/plugins/csvimport/csvdialog.h PRE-CREATION 
  kmymoney/plugins/csvimport/csvdialog.cpp PRE-CREATION 
  kmymoney/plugins/csvimport/csvdialog.ui PRE-CREATION 
  kmymoney/plugins/csvimport/csvimporterdlg.h 5773724 
  kmymoney/plugins/csvimport/csvimporterdlg.cpp 757622f 
  kmymoney/plugins/csvimport/csvimporterdlgdecl.ui e476d0a 
  kmymoney/plugins/csvimport/csvimporterplugin.h 4f3e818 
  kmymoney/plugins/csvimport/csvimporterplugin.cpp 3ec87a3 
  kmymoney/plugins/csvimport/csvimporterrc 672be35 
  kmymoney/plugins/csvimport/csvprocessing.h 21c2720 
  kmymoney/plugins/csvimport/csvprocessing.cpp 00f2815 
  kmymoney/plugins/csvimport/csvutil.h b53cb5a 
  kmymoney/plugins/csvimport/csvutil.cpp fc3d136 
  kmymoney/plugins/csvimport/introwizardpage.ui PRE-CREATION 
  kmymoney/plugins/csvimport/investmentdlg.h b50800d 
  kmymoney/plugins/csvimport/investmentdlg.cpp 679370d 
  kmymoney/plugins/csvimport/investmentwizardpage.ui PRE-CREATION 
  kmymoney/plugins/csvimport/investprocessing.h 337b485 
  kmymoney/plugins/csvimport/investprocessing.cpp feb808b 
  kmymoney/plugins/csvimport/lines-datewizardpage.ui PRE-CREATION 
  kmymoney/plugins/csvimport/redefinedlg.h 1385feb 
  kmymoney/plugins/csvimport/redefinedlg.cpp 332985a 
  kmymoney/plugins/csvimport/redefinedlgdecl.ui 58fc5cd 
  kmymoney/plugins/csvimport/separatorwizardpage.ui PRE-CREATION 
  kmymoney/plugins/csvimport/symboltabledlg.h PRE-CREATION 
  kmymoney/plugins/csvimport/symboltabledlg.cpp PRE-CREATION 
  kmymoney/plugins/csvimport/symboltabledlg.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103142/diff/diff


Testing
-------

Unit tests run, plus astyle and krazy.  Numerous files processed, including live work.


Thanks,

Allan Anderson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111115/34a5f67e/attachment-0001.html>