[Kmymoney-devel] Problem with latest createtarball.rb

[Thomas Baumgart]

Hi,

on Wednesday 09 November 2011 18:36:51 David Houlden wrote:

> On Sunday 06 November 2011 19:59:08 David Houlden wrote:
> > On Sunday 06 November 2011 18:54:41 David Houlden wrote:
> > > On Sunday 06 November 2011 18:02:37 Thomas Baumgart wrote:
> > > > Hi,
> > > > 
> > > > on Sunday 06 November 2011 17:27:33 David Houlden wrote:
> > > > > Hi,
> > > > > 
> > > > > I just ran the latest createtarball as recently modified by Thomas.
> > > > > It did not find any translated documentation or po messages. By
> > > > > adding a few debug print statements it seems there is a problem
> > > > > with the path it constructs for the svn co commands. I just ran
> > > > > "./createtarball.rb -n -a kmymoney".
> > > > > 
> > > > > Here is an example of looking for translated documentation. Note
> > > > > the brackets and quotes around extragear-office.
> > > > > 
> > > > > svn co -q svn://anonsvn.kde.org/home/kde//branches/stable/l10n-
> > > > > kde4/af/docs/["extragear-office"]/kmymoney
> > > > > 
> > > > > I haven't yet worked out why I am getting no translated messages
> > > > > but it may be something similar.
> > > > 
> > > > Very strange. I see the following here on my system:
> > > > 
> > > > svn co -q  svn://anonsvn.kde.org/home/kde//branches/stable/l10n-
> > > > kde4/af/docs/extragear-office/kmymoney > /dev/null 2>&1
> > > > 
> > > > No quotes and brackets at all. Maybe a ruby version problem?
> > > > 
> > > > thb at thb-nb:~/devel/createtarball> ruby --version
> > > > ruby 1.8.7 (2011-02-18 patchlevel 334) [x86_64-linux]
> > > 
> > > Could be a version problem. Here I have
> > > ruby 1.9.1p431 (2011-02-18 revision 30908) [i486-linux]
> > 
> > I just remembered I have a machine which still has ruby 1.8.7 (2009-06-12
> > patchlevel 174) [i486-linux] on it. Createtarball.rb runs ok on that.
> > There must be something different in the way 1.9.1p431 runs the script
> > but I don't have enough ruby knowledge to work it out. If I can help
> > anyone with some testing please let me know.
> 
> OK. I had some spare time so with a bit of reading, very little knowledge
> and a lot of experimenting I have come up with the attached patch which
> makes create_tarball.rb work on both versions of ruby.
> 
> Can someone please check what I have done as I am a bit concerned that the
> same syntax I have changed is used elsewhere in the script such as the line
> temp = { "addPo" =>  [app] }
> 
> If it looks OK then can someone apply the patch for me please.

Looks good to me. Done. Thanks for the time invested.


-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
Real Programmers don't write in PL/I. PL/I is for programmers who
can't decide whether to write in COBOL or FORTRAN.
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111109/f5e4721a/attachment.sig>