[Kmymoney-devel] Re: Fwd: extragear/office/kmymoney/kmymoney/converter

[Cristian Oneț]

On Fri, May 27, 2011 at 1:24 PM, aga <agander93 at gmail.com> wrote:
> On Fri, 27 May 2011 13:04:30 +0300
> Cristian Oneț <onet.cristian at gmail.com> wrote:
>
>> Any ideas why automatic closing of the bug report does not work?
>>
> I received the following "
> You tried to change the Status field from NEW to RESOLVED , but only the assignee or reporter of the bug, or a user with the required permissions may change that field.
>
> Allan Anderson wrote:
>> @bug_id = 273950
>> @bug_status = RESOLVED
>> @resolution = FIXED
> "
>
> Presumably the OP would have to close the bug, but he's on KMM 1.x so
> the fix wont help him.

I closed the bug, please close the review request. To solve this
someone with connections (I'm thinking of Alvaro :) ) at bugs.kde.org
please add Allan's email where it is needed so he can close bugs just
like the rest of the developers do.

Regards,
Cristian

> What is the position for support for KMM 1.x in such situations?
>
> Allan
>
>>
>> SVN commit 1233773 by allananderson:
>
>> ---------- Forwarded message ----------
>> From: Allan Anderson <agander93 at gmail.com>
>> Date: Fri, May 27, 2011 at 12:58 PM
>> Subject: extragear/office/kmymoney/kmymoney/converter
>> To: kde-commits at kde.org
>>
>>
>> SVN commit 1233773 by allananderson:
>>
>> The account contained in the 'L' record gets passed correctly from
>> kmymoney/kmymoney/converter/mymoneyqifreader.cpp to
>> mymoneystatementreader.cpp, as 'brokerageaccount'.  There, however,
>> the 'brokerageactid' does not get set correctly.
>> BUG: 273950
>> REVIEW: 6688
>>
>>
>>  M  +3 -3      mymoneystatementreader.cpp
>>
>>
>> ---
>> trunk/extragear/office/kmymoney/kmymoney/converter/mymoneystatementreader.cpp
>> #1233772:1233773 @@ -220,7 +220,7 @@
>>   // For testing, save the statement to an XML file
>>   // (uncomment this line)
>>   //
>> -  //MyMoneyStatement::writeXMLFile(s,"Imported.Xml");
>> +  MyMoneyStatement::writeXMLFile(s,"Imported.Xml");///
>>
>>   //
>>   // Select the account
>> @@ -542,7 +542,7 @@
>>     // determine the brokerage account
>>     brokerageactid =
>> m_account.value("kmm-brokerage-account").toUtf8(); if
>> (brokerageactid.isEmpty()) {
>> -      brokerageactid =
>> file->accountByName(m_account.brokerageName()).id();
>> +      brokerageactid =
>> file->nameToAccount(t_in.m_strBrokerageAccount); }
>>
>>     // find the security transacted, UNLESS this transaction didn't
>> @@ -1031,7 +1031,7 @@
>>   if (! transfervalue.isZero()) {
>>     // in case the transaction has a reference to the brokerage
>> account, we use it
>>     if (!t_in.m_strBrokerageAccount.isEmpty()) {
>> -      brokerageactid =
>> file->accountByName(t_in.m_strBrokerageAccount).id();
>> +      brokerageactid =
>> file->nameToAccount(t_in.m_strBrokerageAccount); }
>>
>>     if (!brokerageactid.isEmpty()) {
>> _______________________________________________
>> KMyMoney-devel mailing list
>> KMyMoney-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>