[Kmymoney-devel] Review Request: Fix for failure to process correctly an 'L record' with account::sub-account

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6688/
-----------------------------------------------------------

Review request for kmymoney.


Summary
-------

The account contained in the 'L' record gets passed correctly from
kmymoney/kmymoney/converter/mymoneyqifreader.cpp to mymoneystatementreader.cpp,
as 'brokerageaccount'.  There, however, the 'brokerageactid' does not get set
correctly.  The attached patch appears to fix the problem.

With the patch applied, an 'L' record of 'L[Bank-Accounts:chq]' will generate
automatically those two accounts and correctly transfer money into/from
'Bank-Accounts:chq' .  However the asset account automatically created is of
type 'checking'.  So, to achieve what the OP requires, an account of type
'asset' first needs to be created.  Then, the required result is obtained.  If
both the 'Bank-Accounts' and 'chq' accounts are created manually, the same
result is achieved.


This addresses bug 273950.
    https://bugs.kde.org/show_bug.cgi?id=273950


Diffs
-----

  /trunk/extragear/office/kmymoney/kmymoney/converter/mymoneystatementreader.cpp 1233480 

Diff: http://svn.reviewboard.kde.org/r/6688/diff


Testing
-------

Tested with buy, sell and dividend transactions.  Both QIF and CSV imports now
work correctly.


Thanks,

Allan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110525/c1da430d/attachment.htm