[Kmymoney-devel] [Bug 273770] Crash on Gnucash import
Cristian Onet
onet.cristian at gmail.com
Sun May 22 20:20:11 CEST 2011
https://bugs.kde.org/show_bug.cgi?id=273770
Cristian Onet <onet.cristian at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
--- Comment #3 from Cristian Onet <onet cristian gmail com> 2011-05-22 20:20:10 ---
SVN commit 1233113 by conet:
BUG: 273770
Replace all usage of qFatal with qWarning in KMyMoney. I mean I've heard of
assertive programming but this pushes it over the edge. qFatal('Can't open
file') - I prefer letting the user know that there was an error and keep
running to bringing down the whole application (it provides a feeling of
instability) over a file open failure.
If I went too far with this change sorry but I prefer discussing re-adding the
qFatal calls on a point-by-point basis. In most cases it's a shortcut for poor
error handling.
M +13 -13 converter/mymoneygncreader.cpp
M +1 -1 converter/webpricequote.cpp
M +1 -1 mymoney/mymoneyfile.cpp
M +1 -1 mymoney/mymoneytransactionfilter.cpp
M +1 -1 mymoney/storage/mymoneydbdriver.cpp
M +2 -2 mymoney/storage/mymoneystoragesql.cpp
M +1 -1 views/kscheduledview.cpp
M +1 -1 wizards/newloanwizard/keditloanwizard.cpp
WebSVN link: http://websvn.kde.org/?view=rev&revision=1233113
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the KMyMoney-devel
mailing list