[Kmymoney-devel] Re: Review Request: Retain pricing information from manually added transactions

Allan Anderson agander93 at gmail.com
Sat May 14 13:50:59 CEST 2011



> On May 14, 2011, 5:17 a.m., Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp, line 646
> > <http://svn.reviewboard.kde.org/r/6674/diff/1/?file=46149#file46149line646>
> >
> >     Can't you simply break out here? There should be only a single split that contains price information.

yes, of course!  That's what happens when you 'borrow' someone else's code.  If I hadn't, though, I'd no doubt still be ploughing away.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6674/#review10110
-----------------------------------------------------------


On May 14, 2011, 11:50 a.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6674/
> -----------------------------------------------------------
> 
> (Updated May 14, 2011, 11:50 a.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> At the moment pricing information is retained only from imported transactions.
> 
> This fix is to retain prices entered in manually added or edited transactions.
> 
> 
> This addresses bugs 233236 and Bug.
>     https://bugs.kde.org/show_bug.cgi?id=233236
>     https://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp 1231885 
> 
> Diff: http://svn.reviewboard.kde.org/r/6674/diff
> 
> 
> Testing
> -------
> 
> Astyle run.  Several buy, sell and reinvestment transactions entered/edited.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110514/b346e0e1/attachment-0001.htm 


More information about the KMyMoney-devel mailing list