[Kmymoney-devel] Re: Review Request: Use KComboBox instead of KLineEdit for investment security name use.
Cristian Onet
onet.cristian at gmail.com
Wed May 4 13:22:17 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6633/#review10094
-----------------------------------------------------------
Ship it!
Sure, please go ahead and commit it. In the future if the others forget about something like this please feel free to go ahead and commit the changes :).
- Cristian
On March 26, 2011, 8:56 p.m., Allan Anderson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6633/
> -----------------------------------------------------------
>
> (Updated March 26, 2011, 8:56 p.m.)
>
>
> Review request for kmymoney.
>
>
> Summary
> -------
>
> Previously, it was necessary to type in the name whenever a security was to be imported. Instead,
> a KComboBox is used, and security names entered are saved in the resource file, to save inputting
> each time. A button has been added to allow removal of any unwanted or erroneous names from the
> selection list.
>
> Also, a decimal separator now has to be selected before import, to avoid accidental use of a previous,
> wrong type, which could affect imported values.
>
>
> Diffs
> -----
>
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h 1226119
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1226119
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1226119
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1226119
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp 1226119
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1226119
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1226119
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1226119
>
> Diff: http://svn.reviewboard.kde.org/r/6633/diff
>
>
> Testing
> -------
>
> Numerous test files used, plus production files.
>
> Astyle and Krazy2 run.
>
>
> Thanks,
>
> Allan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110504/79a94c1f/attachment.htm
More information about the KMyMoney-devel
mailing list