[Kmymoney-devel] Re: Review Request: CSV Plugin - Add additional unit tests, for decimal symbol logic.

[Cristian Onet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6606/#review9985
-----------------------------------------------------------

Ship it!


It looks good to me. The astyle changes are made with version 1.23 right?

- Cristian


On March 10, 2011, 1:38 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6606/
> -----------------------------------------------------------
> 
> (Updated March 10, 2011, 1:38 p.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> 
> With the recent addition of choice of decimal symbol, a number of unit tests have been added to deal with
> the complexities of data formats, and to make easier the addition of further tests, should they be necessary.
> 
> Also, with the new tabbed UI, there are separate tabs for banking and investment, but just one, common table.
> When switching tabs, the table gets cleared, but if the user accidentally clicks the wrong tab, it is necessary 
> to reselect and reload the file.  I have added logic to issue a warning to guard against this accidental choice.
> Further, I have added an '*' to the label of whichever is the active tab, again to remind the user.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1224392 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/symboltest.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/symboltest.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6606/diff
> 
> 
> Testing
> -------
> 
> Numerous test files, with differing formats and symbols, input successfully.
> Unit testing expanded and completes successfully.
> Krazy2 and astyle run.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110314/6359872c/attachment.htm