[Kmymoney-devel] Re: Review Request: Accounts model optimization

Cristian Onet onet.cristian at gmail.com
Mon Mar 7 19:02:49 CET 2011

This is an automatically generated e-mail. To reply, visit:

(Updated March 7, 2011, 6:02 p.m.)

Review request for kmymoney.


Keep the explicit disconnect after the file has been closed. This must be done since the object added/modified/removed signals are emitted before the AccountsModel is properly loaded (kmymoneyview.cpp:823). The signals must stay connected from after the initial load until the file is closed.


Instead of synchronizing the whole account tree on each data changed take advantage of the new, more granular, signals and perform the appropriate modifications in the model's data after it has been loaded once.

Also create a separate instance for the institutions model. This change has the following rationale. Mixing the two hierarchies in the same model (by account type and institution) would make it difficult to implement changes since depending on the changes it would imply structural modifications in only one instance of the same account. So for example changing the institution means a structural change in the institution hierarchy but no change in the accounts by type hierarchy. Separating the two hierarchies means that one account can be found only once in the model and it also simplifies the implementation of the modifications slots.

This addresses bug 230277.

Diffs (updated)

  /trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.h 1224074 
  /trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.cpp 1224074 
  /trunk/extragear/office/kmymoney/kmymoney/models/models.h 1224074 
  /trunk/extragear/office/kmymoney/kmymoney/models/models.cpp 1224074 
  /trunk/extragear/office/kmymoney/kmymoney/views/kinstitutionsview.cpp 1224074 
  /trunk/extragear/office/kmymoney/kmymoney/views/kmymoneyview.cpp 1224074 

Diff: http://svn.reviewboard.kde.org/r/6589/diff


Simple testing using a test file: adding/removing/modifying accounts and modifying banances.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110307/c1953206/attachment.htm 

More information about the KMyMoney-devel mailing list