[Kmymoney-devel] Re: Review Request: Fixes for problems when importing QIF files containing category/account sub-accounts

[aga]

Also cc List

On Sun, 19 Jun 2011 12:42:11 +0200
Thomas Baumgart <thb at net-bembel.de> wrote:

> Hi,
> 
> on Sunday 19 June 2011 12:35:11 aga wrote:
> 
> > On Sun, 19 Jun 2011 12:13:34 +0200
> > 
> > Thomas Baumgart <thb at net-bembel.de> wrote:
> > > Hi,
> > > 
> > > on Sunday 19 June 2011 12:02:59 Allan Anderson wrote:
> > > > > On June 8, 2011, 8:36 a.m., Thomas Baumgart wrote:
> > > > > > Just had a quick glimpse on the diff, no real testing done
> > > > > > here. This is what I came across.
> > > > 
> > > > If there are no further comments in the next couple of days, I'm
> > > > aiming to commit these changes, to give them some further
> > > > exposure.
> > > 
> > > Please keep in mind, that we are in a release cycle. If this fixes
> > > bugs OK, if it just adds new features, please wait until after the
> > > release.
> > > 
> > > http://techbase.kde.org/Projects/KMyMoney#Release_schedule
> > 
> > Yes, thanks, that's what I had in mind.  There is the bug referred
> > to, but while in that area, I decided extra functionality was
> > needed to deal with the inability manually to add a needed account
> > to an IntInc record that doesn't include one.
> > 
> > I could fairly easily split the two, if you think that preferable.
> > The user who raised the bug wouldn't be impacted, I don't think, as
> > he has brokerage accounts.  I could drop back to diff1 with your
> > points included, and hold off the rest of diff2, possibly.
> 
> I would go for the whole package despite the release. It's more an
> improvement than a new feature AFAICT. Unless there are objections
> from the other devs.
> 
> 

Oh, just a small point I came across.  When manually adding an account
to an IntInc record that is missing one, on entering the edited
transaction, I noticed the Exchange Rate/Price wizard pops up, asking
to convert from GBP to GBP.  Should that happen?  I mean, why should
it?  I can't say I've noticed it previously.  It also comes if an
existing DivX has its value edited.  Seems a little incongruous as no
price is involved.

Allan