[Kmymoney-devel] Re: Review Request: Allow the resizing of the table in the csv importer plugin

[allan]

On 05/01/11 13:45, Cristian Onet wrote:
> This is an automatically generated e-mail. To reply, visit: 
> http://svn.reviewboard.kde.org/r/6279/
>
>
> Review request for kmymoney.
> By Cristian Onet.
>
>
>   Description
>
> With this patch the size of the table is no longer set programmatically but controlled by the size of the dialog + the imported contents. It seems much better this way. This should be also done for the investments. I removed a bit of code that handled setting the column widths Iif I forgot something please let me know.
>
>
>   Diffs
>
>     * trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h
>       (1212010)
>     * trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp
>       (1212010)
>     * trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h
>       (1212010)
>     * trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp
>       (1212010)
>
> View Diff <http://svn.reviewboard.kde.org/r/6279/diff/>
>

Hi Cristian

Just a query about this patch of yours.  Is it the intent that when a 
file is loaded into the UI, it should all be viewable by scrolling, but 
without resizing?

The reason I ask is that I was just checking the text delimiter again 
after Thomas's Krazy patch was applied, and one of the files I was 
checking isn't fully visible without resizing.  It's failing to show the 
last three or so characters on one of the l-o-o-ong lines.  The 
slightest resize fixes it.  Resizing smaller again only goes so far, 
leaving white space at the right side. Scroll left fully from that 
point, and now the  line is fully visible again, and the original 
condition can't now be reproduced, so it's the initial loading that 
slightly adrift, it seems.

Allan