[Kmymoney-devel] Re: Review Request: Migration to AlkValue

[Carlos da Silva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5310/
-----------------------------------------------------------

(Updated Jan. 9, 2011, 6:23 p.m.)


Review request for kmymoney.


Changes
-------

- Updated the patch to revision 1213144 of kmymoney and latest libalkimia.
- Removed libalkimia from the patch (It must be installed in the system).
- Added some debug information in the pivottabletest test case.


Summary (updated)
-------

Porting the mymoneymoney class to AlkValue (from alkimia) in order to deal with overflows (Bug 245214).
Requires the installation of the following packages:
- libalkimia
- GMP library (http://gmplib.org/).

Notes about the development of the patch are in http://community.kde.org/KMyMoney/PlayingWithAlkValue.

This is an updated version using the latest libalkimia and revision r1213144 of kmymoney.


This addresses bug 245214.
    https://bugs.kde.org/show_bug.cgi?id=245214


Diffs (updated)
-----

  /trunk/extragear/office/kmymoney/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/cmake/modules/FindLibalkimia.cmake PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.cpp 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/CMakeLists.txt 1213144 
  /trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.cpp 1213144 

Diff: http://svn.reviewboard.kde.org/r/5310/diff


Testing (updated)
-------

Passed all unit tests present in the code, except pivottabletest and querytabletest.
I have been using this patch with two of my real files, and tested with the files posted in the bug description.


Thanks,

Carlos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110109/e2f42c3f/attachment.htm