[Kmymoney-devel] Re: Review Request: Updates to CSV Plugin
Alvaro Soliverez
asoliverez at kde.org
Wed Jan 5 01:53:02 CET 2011
You might want to take a look at KLocale or talk to John Layt about this. He
is the KDE guy to go about Locales. He's currently on vacation, but we might
get a hold of him here and there.
Please continue this discussion on the list, as the patch is already
commited. At least until there's code to review again.
On Tue, Jan 4, 2011 at 9:43 PM, Allan Anderson <agander93 at gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6238/
>
> On January 4th, 2011, 12:38 p.m., *Cristian Onet* wrote:
>
> I don't know if this ever worked but now that I can import my bank statement with this patch I have a problem with the amounts.
> My bank has '.' as a decimal separator and ',' as thousands separator it seems that the plugin can't handle that. The text delimiter option seems to work fine.
>
> On January 4th, 2011, 12:54 p.m., *Allan Anderson* wrote:
>
> That's strange - those are my settings too. Also, in the file you sent, there is an item with a thousand separator and decimal point and that imports for me OK.
>
> My first thought was your locale settings, but obviously that's daft as you'd have noticed that many moons ago.
>
> What exactly happens? Can you import the file you sent to me? When I import it, all I have to do is set the field separator to ";" and it displays and imports perfectly.
>
> If you are able to anonimize your file in question, I'd better have a look.
>
> On January 4th, 2011, 1:57 p.m., *Allan Anderson* wrote:
>
> An after-thought. It looks like your bank and your locale aren't on speaking terms. If you haven't already tried this, could you temporarily switch to UK locale and try again, please?
>
> On January 4th, 2011, 2:42 p.m., *Cristian Onet* wrote:
>
> Setting the decimal separator in locale to '.' fixes this problem but it leaves my system with a strange locale. AFAIK the MyMoneyMoney object takes the decimal/thousand separator decision based on which one is first (if they are both present) in the string.
>
> On January 4th, 2011, 2:47 p.m., *Cristian Onet* wrote:
>
> Locale should matter when displaying data not when importing it.
>
> On January 4th, 2011, 3:17 p.m., *Allan Anderson* wrote:
>
> < Locale should matter when displaying data not when importing it.
>
> But, how can it display correctly if it hasn't been imported correctly?
>
> I've imported several files in 'EU' locale, by setting my locale appropriately, so to my naive thinking, it looks like the locale is involved.
>
> What do you suggest? I would think that in the majority of cases, a user's file will be in his native locale, but obviously that can't now be taken for granted. The present UI already is pretty busy, and copes with most cases. What about, in the exceptional circumstance, allowing specification of the decimal separator in the resource file, so it's invisible in normal use?
>
> On January 4th, 2011, 3:51 p.m., *Cristian Onet* wrote:
>
> I would prefer autodetection but leave it as it is for now. Please submit the patch.
>
> Now that the patches are out of the way, I've had a quick and dirty first hack at this. With a file having 'EU' type ','
> decimal separator, I've inserted a replace(',', 'locale version'), which does the trick. Needs more thought because the
> decimal separator has now become a thousand separator, and I don't want to convert it back! How fussy are we about
> thousand separators? Could I just remove them? Or, use my brain a bit more?
>
> Then there's the question I raised about how to specify the separator. A couple of extra boxes could go in the UI,
> but I don't like that idea as it's more for users to wade through. I would go for a flag in the resource file.
> Normally it would not be set and no-one would be any the wiser. Except, when it's needed, the user specifies what
> character/s need/s changing into the current locale equivalent.
>
> Should I proceed?
>
>
> - Allan
>
> On December 30th, 2010, 7:05 p.m., Allan Anderson wrote:
> Review request for kmymoney.
> By Allan Anderson.
>
> *Updated 2010-12-30 19:05:47*
> Description
>
> Wish-list Items:
> Addition of UI text delimiter (" or ').
> Addition of handling of line breaks within payee and memo fields.
> Addition of handling of amount sign via a code in another field.
> Bug fixes:
> A much as possible, I've tried to preserve the user's column choices. With further testing and
> live work, it was found that column choices from one file, could, in some circumstances, adversely
> affect a following file having a different format. This in two cases led to KMM crashing or stack
> corruption, through indexes going out of range. It was necessary to drop the preservation of memo
> column settings between files, as the memo field is optional and not guaranteed to be wanted for
> the following file. Also, better range checking of column choices.
> Improved detection of conflicting columns during repeated changing of selections.
> A couple of translation issues addressed.
> Improvement:
> Allow dates with no separators to be handled.
> Tidy up (with white space changes, I'm afraid.
>
> Testing
>
> Intensive stress testing of UI column choices. Many different format files used. Unit test improved.
>
> Diffs
>
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp
> (1210268)
> - /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlgdecl.ui
> (1210268)
>
> View Diff <http://svn.reviewboard.kde.org/r/6238/diff/>
>
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110104/30820606/attachment-0001.htm
More information about the KMyMoney-devel
mailing list