[Kmymoney-devel] Re: Review Request: Updates to CSV Plugin

[Cristian Onet]

> On 2011-01-04 12:38:35, Cristian Onet wrote:
> > I don't know if this ever worked but now that I can import my bank statement with this patch I have a problem with the amounts.
> > My bank has '.' as a decimal separator and ',' as thousands separator it seems that the plugin can't handle that. The text delimiter option seems to work fine.
> 
> Allan Anderson wrote:
>     That's strange - those are my settings too.  Also, in the file you sent, there is an item with a thousand separator and decimal point and that imports for me OK.
>     
>     My first thought was your locale settings, but obviously that's daft as you'd have noticed that many moons ago.
>     
>     What exactly happens?  Can you import the file you sent to me?  When I import it, all I have to do is set the field separator to ";" and it displays and imports perfectly.
>     
>     If you are able to anonimize your file in question, I'd better have a look.
>
> 
> Allan Anderson wrote:
>     An after-thought.  It looks like your bank and your locale aren't on speaking terms.  If you haven't already tried this, could you temporarily switch to UK locale and try again, please?
> 
> Cristian Onet wrote:
>     Setting the decimal separator in locale to '.' fixes this problem but it leaves my system with a strange locale. AFAIK the MyMoneyMoney object takes the decimal/thousand separator decision based on which one is first (if they are both present) in the string.

Locale should matter when displaying data not when importing it.


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6238/#review9508
-----------------------------------------------------------


On 2010-12-30 19:05:47, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6238/
> -----------------------------------------------------------
> 
> (Updated 2010-12-30 19:05:47)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Wish-list Items:
>   Addition of UI text delimiter (" or ').
>   Addition of handling of line breaks within payee and memo fields.
>   Addition of handling of amount sign via a code in another field.
> Bug fixes:
>   A much as possible, I've tried to preserve the user's column choices.  With further testing and
>     live work, it was found that column choices from one file, could, in some circumstances, adversely
>     affect a following file having a different format.  This in two cases led to KMM crashing or stack
>     corruption, through indexes going out of range.  It was necessary to drop the preservation of memo
>     column settings between files, as the memo field is optional and not guaranteed to be wanted for 
>     the following file.  Also, better range checking of column choices.
>   Improved detection of conflicting columns during repeated changing of selections.
>   A couple of translation issues addressed.
> Improvement:
>   Allow dates with no separators to be handled.
>   Tidy up (with white space changes, I'm afraid.  
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1210268 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlgdecl.ui 1210268 
> 
> Diff: http://svn.reviewboard.kde.org/r/6238/diff
> 
> 
> Testing
> -------
> 
> Intensive stress testing of UI column choices.  Many different format files used. Unit test improved.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110104/537ff751/attachment-0001.htm