[Kmymoney-devel] Re: Review Request: Migration to AlkValue

[Allan Anderson]

> On Feb. 28, 2011, 1:10 p.m., Allan Anderson wrote:
> > Looking only at the csv plugin, I can see only one material change.  The remainder seem to be white-space issues, particularly with 'if (...)' or 'for (...)', the original ones coming via astyle.  I was concerned as I'm in mid-change!
> > 
> > Allan
> 
> Thomas Baumgart wrote:
>     If you're in mid-change we can wait until you're done. Please let us know if you want to use this option.

Well, in fact, I'm nearly done.  Some final touches, tidy up and final testing should only take a day or two at the most.

I was assuming I'd be using if only indirectly.  Without having yet read up about it, I was taking it that it would modify mymoneymoney, but I see you refer to it as an option.

My use of mymoneymoney is pretty minimal.  You suggested I use it in place of double where I have to multiply a price by a fraction, and also when applying a fee as a percentage, which I did.  In fact, I still had to use a double to get a string I could format (or so I believed).


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5310/#review9916
-----------------------------------------------------------


On Feb. 27, 2011, 10:40 p.m., Carlos da Silva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5310/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2011, 10:40 p.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Porting the mymoneymoney class to AlkValue (from alkimia) in order to deal with overflows (Bug 245214).
> Requires the installation of the following packages:
> - libalkimia
> - GMP library (http://gmplib.org/).
> 
> Notes about the development of the patch are in http://community.kde.org/KMyMoney/PlayingWithAlkValue.
> 
> This is an updated version using the latest libalkimia and revision r1213144 of kmymoney.
> 
> 
> This addresses bug 245214.
>     https://bugs.kde.org/show_bug.cgi?id=245214
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/cmake/modules/FindLibalkimia.cmake PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/converter/mymoneyqifreader.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/converter/webpricequote.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/knewequityentrydlg.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactionmatcher.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecasttest.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyutils.h 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyutils.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/mymoneybanking.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/numbertowords.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/printcheck.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/CMakeLists.txt 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/reconciliationreport.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/querytable.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kaccountsview.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kbudgetview.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kcategoriesview.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kforecastview.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/views/khomeview.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kinstitutionsview.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kscheduledview.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/transaction.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpage.cpp 1222953 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizard.cpp 1222953 
> 
> Diff: http://svn.reviewboard.kde.org/r/5310/diff
> 
> 
> Testing
> -------
> 
> Passed all unit tests present in the code.
> I have been using this patch with two of my real files, and tested with the files posted in the bug description.
> 
> 
> Thanks,
> 
> Carlos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110228/5eb5ba54/attachment.htm