[Kmymoney-devel] Re: Review Request: Migration to AlkValue

Carlos da Silva kaduardo at gmail.com
Sun Feb 27 23:40:26 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5310/
-----------------------------------------------------------

(Updated Feb. 27, 2011, 10:40 p.m.)


Review request for kmymoney.


Changes
-------

Updated the patch to revision 1222953 of the repository, and included some changes from Thomas.


Summary
-------

Porting the mymoneymoney class to AlkValue (from alkimia) in order to deal with overflows (Bug 245214).
Requires the installation of the following packages:
- libalkimia
- GMP library (http://gmplib.org/).

Notes about the development of the patch are in http://community.kde.org/KMyMoney/PlayingWithAlkValue.

This is an updated version using the latest libalkimia and revision r1213144 of kmymoney.


This addresses bug 245214.
    https://bugs.kde.org/show_bug.cgi?id=245214


Diffs (updated)
-----

  /trunk/extragear/office/kmymoney/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/cmake/modules/FindLibalkimia.cmake PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/converter/mymoneyqifreader.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/converter/webpricequote.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/dialogs/knewequityentrydlg.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/dialogs/transactionmatcher.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecasttest.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyutils.h 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyutils.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/mymoneybanking.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/numbertowords.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/printcheck.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/CMakeLists.txt 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/reconciliationreport.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/reports/querytable.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/views/kaccountsview.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/views/kbudgetview.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/views/kcategoriesview.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/views/kforecastview.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/views/khomeview.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/views/kinstitutionsview.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/views/kscheduledview.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/widgets/transaction.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpage.cpp 1222953 
  /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizard.cpp 1222953 

Diff: http://svn.reviewboard.kde.org/r/5310/diff


Testing (updated)
-------

Passed all unit tests present in the code.
I have been using this patch with two of my real files, and tested with the files posted in the bug description.


Thanks,

Carlos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110227/1b3d587c/attachment.htm 


More information about the KMyMoney-devel mailing list