[Kmymoney-devel] Re: Review Request: Revision to CSV plugin, to have tabbed UI.

[Cristian Onet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6542/#review9900
-----------------------------------------------------------

Ship it!


It's a really big improvement over what we have rigth now. Thanks for this Allan and keep up the good work.

- Cristian


On Feb. 22, 2011, 10:54 a.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6542/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2011, 10:54 a.m.)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Further change to CSV Plugin, following suggestions that the UI be revised to use tabs.  Because this involved combining two UIs into one, and because of similarities in widget naming, a considerable amount of renaming has taken place, adding to the patch size.
> 
> Another suggestion was to allow selection of the decimal symbol, so this is catered for.  While doing this, some identical code was removed from the two major classes and combined in a common class.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.h 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h 1222267 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1222267 
> 
> Diff: http://svn.reviewboard.kde.org/r/6542/diff
> 
> 
> Testing
> -------
> 
> Extensive testing with a number of different file formats, and with comma and dot decimal symbols.  Unit testing completed successfully, although initially the build failed because of the modifications.  Krazy2 and astyle run.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20110222/a80317dc/attachment.htm