[Kmymoney-devel] Review Request: Patch which highlights the online statement balance if different from current file balance

[Thomas Baumgart]

> On Dec. 2, 2011, 10:45 p.m., Marko Käning wrote:
> > kmymoney/mymoney/mymoneyfile.cpp, line 2763
> > <http://git.reviewboard.kde.org/r/103264/diff/6-7/?file=42459#file42459line2763>
> >
> >     Why did you use the path via "_acc.id()" and not the reference variable account directly?

Just to be on the safe side and work with current values. The engine maintains a cache of account objects, so the operation is cheap.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/#review8668
-----------------------------------------------------------


On Dec. 2, 2011, 10:43 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103264/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2011, 10:43 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Highlighting of online statement balance with red background and
> highlighted text if file balance and online balance are different.
> (This patch was put together from Thomas' and Cristian's advice on ML)
> 
> 
> This addresses bug 287494.
>     http://bugs.kde.org/show_bug.cgi?id=287494
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h d44e2ea 
>   kmymoney/mymoney/mymoneyfile.cpp f573f9a 
>   kmymoney/mymoney/mymoneyfiletest.h ad5c687 
>   kmymoney/mymoney/mymoneyfiletest.cpp a3c17ed 
>   kmymoney/widgets/register.h 8cd1a32 
>   kmymoney/widgets/register.cpp e62fe63 
> 
> Diff: http://git.reviewboard.kde.org/r/103264/diff/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Screenshots
> -----------
> 
> small snapshot showing the highlighted group marker
>   http://git.reviewboard.kde.org/r/103264/s/345/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20111203/807a59e3/attachment-0001.html>