[Kmymoney-devel] Review Request: Balance cache object for use by MyMoneyFile

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5404/#review7729
-----------------------------------------------------------



/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.h
<http://svn.reviewboard.kde.org/r/5404/#comment7839>

    Better use "const MyMoneyMoney& balance() const" for improved performance



/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.h
<http://svn.reviewboard.kde.org/r/5404/#comment7840>

    Also, the actual date information of the cache item is lost when calling mostRecentBalance, as only the date passed as the parameter is available to the application. I don't forsee when that information is required in the application, but it might become handy in some circumstances.
    
    In case we keep it, better use "const QDate& date() const" for improved performance


- Thomas


On 2010-09-22 03:08:01, Fernando Vilas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5404/
> -----------------------------------------------------------
> 
> (Updated 2010-09-22 03:08:01)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Initial cut at the balance cache for the MyMoneyFile layer. Nothing uses it other than the test driver yet, but that will change once this is committed. Does it have a reasonable interface? Does it need something else added, like a model interface?
> 
> This interface is subject to change for now, but should be stable enough to start the next phase if it does not need revision first.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1178028 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecachetest.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecachetest.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5404/diff
> 
> 
> Testing
> -------
> 
> Built test driver, and the object passes all tests. Hooray, test-driven-development
> 
> 
> Thanks,
> 
> Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100923/7e0643ff/attachment.htm