[Kmymoney-devel] Review Request: CSVImporter Plugin for KMyMoney

[Allan Anderson]

> On 2010-09-11 18:22:17, Cristian Onet wrote:
> > With dialog-ok and dialog-cancel for now. Should I commit it?

That's great news!!  It's probably best if you do it, as I don't have that access.  However, I've just discovered a minor bug.  I've discovered $0.08 missing!  I've sorted it and it's now working.  I've needed to move a few existing lines into a separate method, which needs to be called from two places, instead of just the present one place.  I was going to show them below, but it's probably safest to send a new version of redefinedlg.cpp.

If that's OK, I'll submit it shortly.

Thanks for all your help.

PS.

As well as a new redefinedlg.cpp, there is a related one-line add to redefinedlg.h.  In addition, a one-line add to 
investmentdlg.cpp, to clear the tablewidget on quitting, in case of re-opening the window.

I've done diffs to head for these.  Is that OK?


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5162/#review7546
-----------------------------------------------------------


On 2010-09-11 10:44:59, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5162/
> -----------------------------------------------------------
> 
> (Updated 2010-09-11 10:44:59)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This is the revised version of the kmymoney csvimporter, which was originally submitted for me by Cristian.  I was unable to find a way to update that, possibly because I was not the original submitter.
> 
> Apart from addressing the original criticisms, I've added further improvements and spent quite a bit of time tightening its error checking.
> 
> As well as the needed files, I've included csvimporterrc.  This is not *needed* by the importer, as it will create one.  However, as the user may wish to supplement the common basic transaction types , in order to cope with his own bank file layout idiosyncrasies, it may serve as an illustration or example.  Where it should reside, I don't know.  I would also wish to include some basic instructions, but in what form, and where?
> 
> Apart from functioning as a plugin, it also can produce QIF files if required.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlgdecl.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5162/diff
> 
> 
> Testing
> -------
> 
> I've run Krazy2 and astyle against it, also unit test.  
> 
> Operationally, I've imported CSV files of checking/savings accounts from a number of UK and other banks.  Also, investment account CSV files from a UK and a US investment institution.
> 
> 
> Screenshots
> -----------
> 
> KListWidget version
>   http://svn.reviewboard.kde.org/r/5162/s/501/
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100912/b352df46/attachment-0001.htm