[Kmymoney-devel] Review Request: CSVImporter Plugin for KMyMoney

[Alvaro Soliverez]

On Fri, Sep 10, 2010 at 7:40 AM, allan <aganderson at ukonline.co.uk> wrote:
> On 10/09/10 04:20, Alvaro Soliverez wrote:
>> This is an automatically generated e-mail. To reply, visit:
>> http://svn.reviewboard.kde.org/r/5162/
>>
>>
>>     On September 8th, 2010, 6:28 p.m., *Cristian Onet* wrote:
>>
>>         Please add the following missing files from the patch:
>>         redefinedlgdecl.ui - missing from the patch
>>         tick.png - present in the patch but since it's a binary it must be sent to the mailing list or directly to me (since the patch does not contain the actual binary file)
>>         nogo.png - the same as the above
>>
>>     On September 9th, 2010, 7:59 p.m., *Alvaro Soliverez* wrote:
>>
>>         Those two png files. From the file names I assume those are icon files. Can't we use standard KDE icons for that instead of adding even more icons?
>>         We are trying to use standard icons or have Oxygen build icons and include them in the standard set whenever possible.
>>
>>     On September 9th, 2010, 9:19 p.m., *Allan Anderson* wrote:
>>
>>         Cristian made the same point to me offline.:-
>>
>>         > Hi,
>>         > >
>>         > > Would you agree to using the standard KDE icons for these actions
>>         > > instead of adding these two icons? I think it would be better that way
>>         > > since the two icons really resemble the KDE standard ones so it would
>>         > > be better to avoid duplication.
>>         "
>>         Hi Cristian
>>
>>         I did try them, but felt they were a bit overpowering, with having a
>>         number of them in a small area.  I also tried the flag icons, but they
>>         were the opposite.  I'll have another look, though.
>>         "
>>
>>          I've since responded as follows:
>>         "
>>         Hi Cristian
>>
>>         I've had another look, and I have to say I don't like the standard
>>         dialog-ok and dialog-cancel in this use.
>>
>>         By standard KDE icons, do you mean just the the oxygen?  What about
>>         hicolor?  These seem to be more suited for the drop-down -
>>
>>         /usr/share/icons/hicolor/16x16/apps/gdu-smart-healthy.png and
>>         gdu-smart-failing.png, although the names aren't helpful
>>
>>
>>         If not, then I guess it has to be the standard dialog-ok and dialog-cancel."
>>         -----------------------------
>>
>>         I'm happy to drop my own icons if the hicolor ones are acceptable.
>>
>>         If it has to be the oxygen ones, then so be it, but they do jump out at you in this context.
>>
>>
>>
>> Can you send a screenshot to the list to understand why the standard icons are not suitable for this? My setup is too modified at the moment to add yet another patch.
>>
>> - Alvaro
>>
>
> Here are three snapshots, of the oxygen version, the gdu-smart one and
> my custom icons.  (A tar file was no smaller.)
>
> If I'm making a fuss over nothing, then just say and I'll go with the
> oxygen ones!
>
> Allan
>
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>
>

What's the intention of the icons? Showing what you can or can't select?

Perhaps you should use the list-add, list-remove icons.