[Kmymoney-devel] Review Request: Cache the account and institution icons

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5302/#review7515
-----------------------------------------------------------


It works here on 4.3.5.  Where should be the speedup?

- Thomas


On 2010-09-10 03:18:12, Alvaro Soliverez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5302/
> -----------------------------------------------------------
> 
> (Updated 2010-09-10 03:18:12)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Use QPixmapCache to avoid rendering account and institution icons every time
> 
> 
> This addresses bug 235882.
>     https://bugs.kde.org/show_bug.cgi?id=235882
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyaccount.cpp 1173232 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyinstitution.cpp 1173232 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneyaccountselector.cpp 1173232 
> 
> Diff: http://svn.reviewboard.kde.org/r/5302/diff
> 
> 
> Testing
> -------
> 
> Opened, entered a couple of transactions. All icons seem to be there.
> 
> I tested with KDE SC 4.5 and Qt 4.6. Please check with KDE 4.3
> 
> 
> Thanks,
> 
> Alvaro
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100910/6a741a17/attachment.htm