[Kmymoney-devel] Review Request: Show prices in investment reports only if they exist

[Alvaro Soliverez]

> On 2010-09-10 02:57:38, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/reports/pivottable.cpp, line 1028
> > <http://svn.reviewboard.kde.org/r/5298/diff/1/?file=35571#file35571line1028>
> >
> >     This is the call you should modify to fetch prices for the exact date, if a flag is set in the config of the report (say config.skipZero)
> >     
> >     In line 109 of reportaccount.cpp, the call should be
> >     MyMoneyPrice price = file->price(undersecurity.id(), undersecurity.tradingCurrency(), date, <new parameter>);
> >     
> >     That should return zero if exactDate, the last parameter, is set to true.

Check if MyMoneyPrice.isValid(), set the conversionFactor to zero if false.


- Alvaro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5298/#review7510
-----------------------------------------------------------


On 2010-09-09 19:16:33, Bernd Gonsior wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5298/
> -----------------------------------------------------------
> 
> (Updated 2010-09-09 19:16:33)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Patch for investment reports only: prices are shown only if at least one price
> exists in a requested period.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/kreportchartview.h 1173571 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/kreportchartview.cpp 1173571 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivottable.h 1173571 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivottable.cpp 1173571 
> 
> Diff: http://svn.reviewboard.kde.org/r/5298/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100910/1ed54fb0/attachment.htm