[Kmymoney-devel] Review Request: Show prices in investment reports only if they exist

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5298/#review7509
-----------------------------------------------------------



/trunk/extragear/office/kmymoney/kmymoney/reports/kreportchartview.cpp
<http://svn.reviewboard.kde.org/r/5298/#comment7698>

    This should be done based on the configuration of the report, and not the account type. ie. you want to skip data points when painting a price, not when drawing the net worth


Use MyMoneyReport, which stores the report configuration, and add a flag to signal whether empty prices should be skipped or not. Then skip drawind the data altogether.

For that to work correctly, the LineAttributes has a MissingValuesPolicy. Calling setMissingValuesPolicy(LineAttributes::MissingValuesAreBridged) should be enough for that.

- Alvaro


On 2010-09-09 19:16:33, Bernd Gonsior wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5298/
> -----------------------------------------------------------
> 
> (Updated 2010-09-09 19:16:33)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Patch for investment reports only: prices are shown only if at least one price
> exists in a requested period.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/kreportchartview.h 1173571 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/kreportchartview.cpp 1173571 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivottable.h 1173571 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivottable.cpp 1173571 
> 
> Diff: http://svn.reviewboard.kde.org/r/5298/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100910/329fd4c7/attachment-0001.htm