[Kmymoney-devel] Review Request: CSVImporter Plugin for KMyMoney

[Allan Anderson]

> On 2010-09-08 18:28:29, Cristian Onet wrote:
> > Please add the following missing files from the patch:
> > redefinedlgdecl.ui - missing from the patch
> > tick.png - present in the patch but since it's a binary it must be sent to the mailing list or directly to me (since the patch does not contain the actual binary file)
> > nogo.png - the same as the above
> 
> Alvaro Soliverez wrote:
>     Those two png files. From the file names I assume those are icon files. Can't we use standard KDE icons for that instead of adding even more icons? 
>     We are trying to use standard icons or have Oxygen build icons and include them in the standard set whenever possible.

Cristian made the same point to me offline.:-

> Hi,
> > 
> > Would you agree to using the standard KDE icons for these actions
> > instead of adding these two icons? I think it would be better that way
> > since the two icons really resemble the KDE standard ones so it would
> > be better to avoid duplication.
"
Hi Cristian

I did try them, but felt they were a bit overpowering, with having a
number of them in a small area.  I also tried the flag icons, but they
were the opposite.  I'll have another look, though.
"

 I've since responded as follows:
"
Hi Cristian

I've had another look, and I have to say I don't like the standard
dialog-ok and dialog-cancel in this use.

By standard KDE icons, do you mean just the the oxygen?  What about
hicolor?  These seem to be more suited for the drop-down -

/usr/share/icons/hicolor/16x16/apps/gdu-smart-healthy.png and
gdu-smart-failing.png, although the names aren't helpful


If not, then I guess it has to be the standard dialog-ok and dialog-cancel."
-----------------------------

I'm happy to drop my own icons if the hicolor ones are acceptable.

If it has to be the oxygen ones, then so be it, but they do jump out at you in this context.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5162/#review7481
-----------------------------------------------------------


On 2010-09-08 22:29:47, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5162/
> -----------------------------------------------------------
> 
> (Updated 2010-09-08 22:29:47)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This is the revised version of the kmymoney csvimporter, which was originally submitted for me by Cristian.  I was unable to find a way to update that, possibly because I was not the original submitter.
> 
> Apart from addressing the original criticisms, I've added further improvements and spent quite a bit of time tightening its error checking.
> 
> As well as the needed files, I've included csvimporterrc.  This is not *needed* by the importer, as it will create one.  However, as the user may wish to supplement the common basic transaction types , in order to cope with his own bank file layout idiosyncrasies, it may serve as an illustration or example.  Where it should reside, I don't know.  I would also wish to include some basic instructions, but in what form, and where?
> 
> Apart from functioning as a plugin, it also can produce QIF files if required.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlgdecl.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5162/diff
> 
> 
> Testing
> -------
> 
> I've run Krazy2 and astyle against it, also unit test.  
> 
> Operationally, I've imported CSV files of checking/savings accounts from a number of UK and other banks.  Also, investment account CSV files from a UK and a US investment institution.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100909/419356a3/attachment.htm