[Kmymoney-devel] Review Request: Make sure transactions have a unique ID after loading from file

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5287/#review7488
-----------------------------------------------------------

Ship it!


It looks ok, though I'd still like to have this on the consistency check too.

- Alvaro


On 2010-09-08 08:46:20, Thomas Baumgart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5287/
> -----------------------------------------------------------
> 
> (Updated 2010-09-08 08:46:20)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> The patch provided with r1156689 does not completely solve the problem. Rather than detecting any duplicates, it is easier to assign a new transaction ID during the loading of an XML file. Since there is no relation of the transaction ID to or from other objects, this can be performed without further changes/checks.
> 
> Once approved, the patch needs to be backported to the 4.5 branch.
> 
> 
> This addresses bug 246108.
>     https://bugs.kde.org/show_bug.cgi?id=246108
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp 1172072 
>   trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h 1172072 
>   trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp 1172072 
>   trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp 1172072 
> 
> Diff: http://svn.reviewboard.kde.org/r/5287/diff
> 
> 
> Testing
> -------
> 
> Created special file with duplicate transaction IDs.
> Loaded file, saved it and verified that the duplicate transaction IDs have been resolved.
> 
> Loaded my 2 real data files, made changes and saved them. Verified, that all global values remain the same.
> 
> Ran unit tests w/o problems.
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100909/bba1edd2/attachment.html