[Kmymoney-devel] Review Request: new payee fields: bank code number and account number

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5189/#review7360
-----------------------------------------------------------


Sorry to jump a bit late into the review.

This is not enough AFAICT. The use case to support is to have multiple accounts per institution per payee. I have multiple accounts at various banks each so this does not help at all because the fields will be overridden each time I do a download. Or am I missing something?

- Thomas


On 2010-09-02 08:22:00, Sebastian Held wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5189/
> -----------------------------------------------------------
> 
> (Updated 2010-09-02 08:22:00)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Please refer to BUG 249403 (new payee fields: bank code number and account number)
> This patch includes the database changes. I'm not sure, if I got the db stuff right.
> 
> This review board didn't accept my git diffs... Thus the diff is created by post-review; I hope it's complete.
> 
> 
> This addresses bug 249403.
>     https://bugs.kde.org/show_bug.cgi?id=249403
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayee.h 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayee.cpp 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydbdef.cpp 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.h 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kpayeesview.cpp 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kpayeesviewdecl.ui 1169309 
> 
> Diff: http://svn.reviewboard.kde.org/r/5189/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100902/e9bc9e24/attachment.htm