[Kmymoney-devel] Re: Review Request: csvplugin update to add additional unit test, and improve field delimiter handling

[Allan Anderson]

> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp, line 64
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38578#file38578line64>
> >
> >     I am missing the corresponding delete in the dtor

Done


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp, line 367
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38578#file38578line367>
> >
> >     Ah, here is the initilization. Please use a setter/getter if you want to access member vars outside of the object.

I've attended to the ones in ParseLine, but I'm sure there will be others to do.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h, line 43
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38579#file38579line43>
> >
> >     Members should be non-public. Use getter/setter methods

As above.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp, line 24
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38580#file38580line24>
> >
> >     Initialize members here if they don't have auto-initialization, e.g. 'int', 'double', etc.

Done, but probably more to do.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp, line 40
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38580#file38580line40>
> >
> >     Where is the initialization of m_fieldDelimerIndex?

Is this query answered by your comment three lines up?  ParseLine is called from csvprocessing, investprocessing, or parsedatatest.  Each of these initialises this index before it is used.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h, line 69
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38582#file38582line69>
> >
> >     Members should be non-public

I need to go through the lot.  To be continued.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5463/#review8146
-----------------------------------------------------------


On 2010-09-27 16:53:42, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5463/
> -----------------------------------------------------------
> 
> (Updated 2010-09-27 16:53:42)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> The initial intention was to add an additional unit test, which involved removing data line parsing from the displayLine() routine into a small separate class to enable access from the unit test routine.  This led to benefits in two other areas.  
> 
> One csv test file I have had a comma as thousand separator, which was conflicting with the comma field separator.  Initially, I looked at this from the point of view of field separators and concocted a separator which successfully dealt with the issue.  However, I realised that the same odd separator might not work in another similar situation.  So, I've improved the detection and handling of this issue.
> 
> This then led to changes in csvProcessing() and investProcessing(), removing redundant code and improving efficiency slightly.
> 
> Two UIs have had a now unneeded field separator combobox item removed.  Some minor purely cosmetic changes also have been made.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1180212 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1180212 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1180212 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1180212 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui 1180212 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1180212 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1180212 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1180212 
> 
> Diff: http://svn.reviewboard.kde.org/r/5463/diff
> 
> 
> Testing
> -------
> 
> The new parsedatatest() unit test runs successfully.  Krazy and astyle have been run. Functional testing done with various csv format files.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101015/34ea0791/attachment-0001.htm