[Kmymoney-devel] Re: Review Request: Balance cache object for use by MyMoneyFile

[Fernando Vilas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5404/
-----------------------------------------------------------

(Updated 2010-10-01 15:56:54.013026)


Review request for kmymoney.


Changes
-------

Cache updated to only store MyMoneyMoney objects, but still return CacheItems. 
CacheItem updated to return references. 
CacheItem no-arg ctor commented out, since it is not needed. Code is kept in case a need arises during integration.

I have not yet evaluated what to cache, in terms of dates. This will be evaluated when MMFile starts actually using the cache.


Summary
-------

Initial cut at the balance cache for the MyMoneyFile layer. Nothing uses it other than the test driver yet, but that will change once this is committed. Does it have a reasonable interface? Does it need something else added, like a model interface?

This interface is subject to change for now, but should be stable enough to start the next phase if it does not need revision first.


Diffs (updated)
-----

  /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1181614 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.cpp PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecachetest.h PRE-CREATION 
  /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecachetest.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5404/diff


Testing
-------

Built test driver, and the object passes all tests. Hooray, test-driven-development


Thanks,

Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101001/820fec53/attachment.htm