[Kmymoney-devel] Re: Review Request: csvplugin update to add additional unit test, and improve field delimiter handling

[Allan Anderson]

> On 2010-11-27 09:50:27, Cristian Onet wrote:
> > Hi Allan,
> > 
> > While your at it could you improve the messages of the plugin. Right now I'm trying to translate the strings and they look a bit messy. There are a lot of messages like:
> > 
> > That column, or the amount field, is already 
> > selected!                                     <center>Please select a 
> > different column or field.</center>
> > 
> > That column, or the price field, is already 
> > selected!                                     <center>Please select a 
> > different column or field.</center>
> > 
> > Could this be reorganized somehow? I also observed that the same message is there more then once with only whitespace differences. Those matter for the translation tools.
> > 
> > Thanks,
> > Cristian

Hi Cristian

Some of these already had been changed, but I've now gone through them all.  Hopefully, they will now translate better, although there might be a little less symmetry in their appearance.  If the translation tools are better than my eyesight and anything else shows up, just shout and I'll have to look more closely. (See newest patch set.)


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5463/#review9003
-----------------------------------------------------------


On 2010-11-08 11:58:51, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5463/
> -----------------------------------------------------------
> 
> (Updated 2010-11-08 11:58:51)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> The initial intention was to add an additional unit test, which involved removing data line parsing from the displayLine() routine into a small separate class to enable access from the unit test routine.  This led to benefits in two other areas.  
> 
> One csv test file I have had a comma as thousand separator, which was conflicting with the comma field separator.  Initially, I looked at this from the point of view of field separators and concocted a separator which successfully dealt with the issue.  However, I realised that the same odd separator might not work in another similar situation.  So, I've improved the detection and handling of this issue.
> 
> This then led to changes in csvProcessing() and investProcessing(), removing redundant code and improving efficiency slightly.
> 
> Two UIs have had a now unneeded field separator combobox item removed.  Some minor purely cosmetic changes also have been made.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h 1194236 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1194236 
> 
> Diff: http://svn.reviewboard.kde.org/r/5463/diff
> 
> 
> Testing
> -------
> 
> The new parsedatatest() unit test runs successfully.  Krazy and astyle have been run. Functional testing done with various csv format files.
> 
> Also, built and tested on a Ubuntu box, as well as openSuse. 800x600 and 1280x1024 resolutions checked, and different font sizes tested.
> 
> In use for my production.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101130/146dd9da/attachment.htm