[Kmymoney-devel] Re: Review Request: Optimize vertical space usage in the budgets view and in the forecast view.

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5927/#review8967
-----------------------------------------------------------

Ship it!


It looks ok to me.

- Alvaro


On 2010-11-24 20:56:24, Cristian Onet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5927/
> -----------------------------------------------------------
> 
> (Updated 2010-11-24 20:56:24)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This work is a part of the fix for https://bugs.kde.org/show_bug.cgi?id=256769 plus some other fixes will be needed.
> Since computer screens (at least the newer ones) tend to have more horizontal space then vertical space I think these improvements are welcomed. Since only ui files where changed there is no code to review just to look at the screenshots or try the patch and say what you think about it.
> 
> 
> This addresses bug 256769.
>     https://bugs.kde.org/show_bug.cgi?id=256769
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/office/kmymoney/kmymoney/dialogs/settings/ksettingsgeneraldecl.ui 1200040 
>   trunk/extragear/office/kmymoney/kmymoney/views/kbudgetviewdecl.ui 1200040 
>   trunk/extragear/office/kmymoney/kmymoney/views/kforecastviewdecl.ui 1200040 
> 
> Diff: http://svn.reviewboard.kde.org/r/5927/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Budgets layout change
>   http://svn.reviewboard.kde.org/r/5927/s/560/
> Forecast layout change
>   http://svn.reviewboard.kde.org/r/5927/s/561/
> 
> 
> Thanks,
> 
> Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101124/b47dbbc6/attachment.htm