[Kmymoney-devel] Re: Review Request: csvplugin update to add additional unit test, and improve field delimiter handling

[Allan Anderson]

> On 2010-11-05 07:27:28, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h, line 65
> > <http://svn.reviewboard.kde.org/r/5463/diff/3/?file=40633#file40633line65>
> >
> >     I almost expected this to happen: The Qt naming conventions state, that the syllable 'get' is not written, thus e.g. 'getCreditColumn' should be named 'creditColumn'. Applies to many more 'getters'.

Many, indeed.  Done.  I nearly got caught out by several KDE gets!  (They don't know?)  Also, changed a couple of names which would have been pretty meaningless without the get.


> On 2010-11-05 07:27:28, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp, line 798
> > <http://svn.reviewboard.kde.org/r/5463/diff/3/?file=40644#file40644line798>
> >
> >     That doesn't make a difference. If type is used as a variable to return something from processActionType() than 'QString& type' is better suited than 'QString* type'. Any initial comment from me on this might have been misleading. Sorry.

Done


> On 2010-11-05 07:27:28, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h, line 107
> > <http://svn.reviewboard.kde.org/r/5463/diff/3/?file=40647#file40647line107>
> >
> >     If possible, you should use the MyMoneyMoney object in favor of doubles/floats.

Done.
Diff take 4 to follow, after a few more tests.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5463/#review8512
-----------------------------------------------------------


On 2010-11-04 18:16:34, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5463/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 18:16:34)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> The initial intention was to add an additional unit test, which involved removing data line parsing from the displayLine() routine into a small separate class to enable access from the unit test routine.  This led to benefits in two other areas.  
> 
> One csv test file I have had a comma as thousand separator, which was conflicting with the comma field separator.  Initially, I looked at this from the point of view of field separators and concocted a separator which successfully dealt with the issue.  However, I realised that the same odd separator might not work in another similar situation.  So, I've improved the detection and handling of this issue.
> 
> This then led to changes in csvProcessing() and investProcessing(), removing redundant code and improving efficiency slightly.
> 
> Two UIs have had a now unneeded field separator combobox item removed.  Some minor purely cosmetic changes also have been made.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1193061 
> 
> Diff: http://svn.reviewboard.kde.org/r/5463/diff
> 
> 
> Testing
> -------
> 
> The new parsedatatest() unit test runs successfully.  Krazy and astyle have been run. Functional testing done with various csv format files.
> 
> Also, built and tested on a Ubuntu box, as well as openSuse. 800x600 and 1280x1024 resolutions checked, and different font sizes tested.
> 
> In use for my production.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101106/d499a8f9/attachment-0001.htm