[Kmymoney-devel] Re: Review Request: csvplugin update to add additional unit test, and improve field delimiter handling

[Allan Anderson]

> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp, line 151
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38584#file38584line151>
> >
> >     Use i18n here (and all other translatable strings)

Sorry, I'd missed a few.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp, line 921
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38583#file38583line921>
> >
> >     better pass column as "const QString& column"

Done


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp, line 931
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38583#file38583line931>
> >
> >     better pass aName as "const QString& aName"

Thought I'd done all these.  Done


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp, line 126
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38584#file38584line126>
> >
> >     Better pass type as "const QString& type"

Couldn't do this, as type gets modified.  Changed to pass by reference.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h, line 69
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38582#file38582line69>
> >
> >     Members should be non-public
> 
> Allan Anderson wrote:
>     I need to go through the lot.  To be continued.

Done.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h, line 43
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38579#file38579line43>
> >
> >     Members should be non-public. Use getter/setter methods
> 
> Allan Anderson wrote:
>     As above.

All completed.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp, line 56
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38583#file38583line56>
> >
> >     Missing call of base class ctor here.
> 
> Allan Anderson wrote:
>     Sorry, but I'm not sure what you mean here.

Sorry, but still unclear on what's needed


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp, line 367
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38578#file38578line367>
> >
> >     Ah, here is the initilization. Please use a setter/getter if you want to access member vars outside of the object.
> 
> Allan Anderson wrote:
>     I've attended to the ones in ParseLine, but I'm sure there will be others to do.

All done.


> On 2010-10-14 11:36:15, Thomas Baumgart wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp, line 24
> > <http://svn.reviewboard.kde.org/r/5463/diff/1/?file=38580#file38580line24>
> >
> >     Initialize members here if they don't have auto-initialization, e.g. 'int', 'double', etc.
> 
> Allan Anderson wrote:
>     Done, but probably more to do.

Am I on the right lines, before I go any further?


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5463/#review8146
-----------------------------------------------------------


On 2010-11-04 18:16:34, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5463/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 18:16:34)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> The initial intention was to add an additional unit test, which involved removing data line parsing from the displayLine() routine into a small separate class to enable access from the unit test routine.  This led to benefits in two other areas.  
> 
> One csv test file I have had a comma as thousand separator, which was conflicting with the comma field separator.  Initially, I looked at this from the point of view of field separators and concocted a separator which successfully dealt with the issue.  However, I realised that the same odd separator might not work in another similar situation.  So, I've improved the detection and handling of this issue.
> 
> This then led to changes in csvProcessing() and investProcessing(), removing redundant code and improving efficiency slightly.
> 
> Two UIs have had a now unneeded field separator combobox item removed.  Some minor purely cosmetic changes also have been made.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h 1193061 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1193061 
> 
> Diff: http://svn.reviewboard.kde.org/r/5463/diff
> 
> 
> Testing
> -------
> 
> The new parsedatatest() unit test runs successfully.  Krazy and astyle have been run. Functional testing done with various csv format files.
> 
> Also, built and tested on a Ubuntu box, as well as openSuse. 800x600 and 1280x1024 resolutions checked, and different font sizes tested.
> 
> In use for my production.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101104/ff248b45/attachment-0001.htm