[Kmymoney-devel] Review Request: KMM bug #240629 - Progress bar does not reach 100% but count does.

[Fernando Vilas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4417/#review6248
-----------------------------------------------------------


I can confirm that the database backend is affected. However, the patch does not seem to help. There may be a larger issue with the UI not updating while the home page is loading. The progress bar only updates occasionally, so it is hard to tell if the patch works or not.

- Fernando


On 2010-06-22 12:46:36, Vincent Ordy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4417/
> -----------------------------------------------------------
> 
> (Updated 2010-06-22 12:46:36)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> - set progressbar value to 0 after a reset (reset() sets it to -1, which is
> invalid and cause this bug)
> - increment the progressbar value only when appropriate.  Some elements like <budgets> do not initialize the progressbar, but the progressbar value was incremented => the value become greater than the maximum => the progressbar is reset by Qt.
> - remove useless resets
> 
> 
> This addresses bug 240629.
>     https://bugs.kde.org/show_bug.cgi?id=240629
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1140640 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp 1140640 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp 1140640 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneymvccombo.cpp 1140640 
> 
> Diff: http://reviewboard.kde.org/r/4417/diff
> 
> 
> Testing
> -------
> 
> build + load 2 files w/ the progressbar timer disabled (kmymoney/kmymoney.cpp:1932) to slow down the progress
> 
> 
> Thanks,
> 
> Vincent
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100623/cf5845ba/attachment.htm