[Kmymoney-devel] Review Request: KMM bug #240629 - Progress bar does not reach 100% but count does.

[Alvaro Soliverez]

Fernando, Tony,
can you verify whether the DB backend is affected by this bug, and review
this patch accordingly?

Regards,
Alvaro

On Tue, Jun 22, 2010 at 9:43 AM, Vincent Ordy <vincent at ordy.net> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4417/
>
> On June 22nd, 2010, 9:27 a.m., *Thomas Baumgart* wrote:
>
> I understand and support the changes to the XML backend, but I don't know if we really need a progress bar for the SQL backend. In case we do, please replace QObject::tr with a call to KDE's i18n function.
>
> I noticed two things in the XML backend changes:
>
>    int count = atts.value(QString("count")).toUInt();
>
> a) Why do you use an "int" and assign it an "unsigned int"?
> b) Using QLatin1String("count") is better than QString("count")
>
> Details for b) can be found on http://labs.trolltech.com/blogs/2008/04/28/string-theory/
>
>  This line is a copy of lines 167, 174, 181, 188, and 195 that were already there.  I should have payed attention though.  Thanks for the pointer on QLatin1String.
>
> I'm going to update the patch to fix that.
>
> Alvaro asked me on bugzilla if the database storage was affected by the progress bar bug so I fixed it, but I really don't mind if you drop it (I've never even used the SQL storage before).
>
>
> - Vincent
>
> On June 22nd, 2010, 4:58 a.m., Vincent Ordy wrote:
>   Review request for kmymoney.
> By Vincent Ordy.
>
> *Updated 2010-06-22 04:58:04*
> Description
>
> - set progressbar value to 0 after a reset (reset() sets it to -1, which is
> invalid and cause this bug)
> - increment the progressbar value only when appropriate.  Some elements like <budgets> do not initialize the progressbar, but the progressbar value was incremented => the value become greater than the maximum => the progressbar is reset by Qt.
> - remove useless resets
>
>   Testing
>
> build + load 2 files w/ the progressbar timer disabled (kmymoney/kmymoney.cpp:1932) to slow down the progress
>
>   *Bugs: * 240629 <https://bugs.kde.org/show_bug.cgi?id=240629>
> Diffs
>
>    - /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp (1140640)
>    - /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp
>    (1140640)
>    - /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp
>    (1140640)
>
> View Diff <http://reviewboard.kde.org/r/4417/diff/>
>
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100622/8253e3cd/attachment.htm