[Kmymoney-devel] Review Request: KMM bug #240629 - Progress bar does not reach 100% but count does.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4417/#review6228
-----------------------------------------------------------


I understand and support the changes to the XML backend, but I don't know if we really need a progress bar for the SQL backend. In case we do, please replace QObject::tr with a call to KDE's i18n function.

I noticed two things in the XML backend changes:

   int count = atts.value(QString("count")).toUInt();

a) Why do you use an "int" and assign it an "unsigned int"?
b) Using QLatin1String("count") is better than QString("count")

Details for b) can be found on http://labs.trolltech.com/blogs/2008/04/28/string-theory/

- Thomas


On 2010-06-22 04:58:04, Vincent Ordy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4417/
> -----------------------------------------------------------
> 
> (Updated 2010-06-22 04:58:04)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> - set progressbar value to 0 after a reset (reset() sets it to -1, which is
> invalid and cause this bug)
> - increment the progressbar value only when appropriate.  Some elements like <budgets> do not initialize the progressbar, but the progressbar value was incremented => the value become greater than the maximum => the progressbar is reset by Qt.
> - remove useless resets
> 
> 
> This addresses bug 240629.
>     https://bugs.kde.org/show_bug.cgi?id=240629
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1140640 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp 1140640 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp 1140640 
> 
> Diff: http://reviewboard.kde.org/r/4417/diff
> 
> 
> Testing
> -------
> 
> build + load 2 files w/ the progressbar timer disabled (kmymoney/kmymoney.cpp:1932) to slow down the progress
> 
> 
> Thanks,
> 
> Vincent
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100622/26bc3708/attachment.htm