[Kmymoney-devel] Review Request: Port unit tests to QTest

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4408/#review6195
-----------------------------------------------------------


If I remove cppunit from the system, I get this error when compiling from scratch. If I build with cppunit still in, it works fine.

[ 17%] Building CXX object kmymoney/models/CMakeFiles/models.dir/accountsmodel.cpp.o
In file included from /home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/models/accountsmodel.cpp:38:0:                                                                                                                  
/home/al/desarrollo/kmm/kde4/kmymoney/kmymoney/kmymoneyglobalsettings.h:33:30: error fatal: kmymoneysettings.h: No existe el fichero o el directorio
compilación terminada.
make[2]: *** [kmymoney/models/CMakeFiles/models.dir/accountsmodel.cpp.o] Error 1
make[1]: *** [kmymoney/models/CMakeFiles/models.dir/all] Error 2
make: *** [all] Error 2

There is still a cppunit dependency somewhere in there.

- Alvaro


On 2010-06-20 13:13:07, Fernando Vilas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4408/
> -----------------------------------------------------------
> 
> (Updated 2010-06-20 13:13:07)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This patch removes the dependency on CPPUNIT for the unit tests. As part of that, there is no longer a kmymoneytest executable created. The tests are all individual and can be executed with "make test", or called individually.
> 
> Most of the port is s/CPPUNIT_FAIL/QFAIL/g and s/CPPUNIT_ASSERT/QVERIFY/g.
> 
> The web quotes test has an example of data driven testing, which we may use more in later unit test updates.
> 
> The patch is fairly large, so I want some others to review it before I commit.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/CMakeLists.txt 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/converter/CMakeLists.txt 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/converter/convertertest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/converter/convertertest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/kmymoneytest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/main.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyaccounttest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyaccounttest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyexceptiontest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyexceptiontest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfiletest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfiletest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfinancialcalculatortest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfinancialcalculatortest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecasttest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecasttest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyinstitutiontest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyinstitutiontest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneykeyvaluecontainertest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneykeyvaluecontainertest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyobjecttest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyobjecttest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayeetest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayeetest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypricetest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypricetest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduletest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduletest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysecuritytest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysecuritytest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysplittest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysplittest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneytestutils.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneytransactiontest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneytransactiontest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyutils.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/CMakeLists.txt 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneymaptest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneymaptest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/CMakeLists.txt 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivotgridtest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivotgridtest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.cpp 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/querytabletest.h 1140349 
>   /trunk/extragear/office/kmymoney/kmymoney/reports/querytabletest.cpp 1140349 
> 
> Diff: http://reviewboard.kde.org/r/4408/diff
> 
> 
> Testing
> -------
> 
> All tests were ported, and remain passing.
> 
> 
> Thanks,
> 
> Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100620/9787d123/attachment.htm